Allow int for max_warnings in TOML - #14954
Open
Dmao233 wants to merge 4 commits into
Open
Conversation
The max_warnings option was registered without a type (defaulting to 'string'), so integer values in native TOML config raised a TypeError. It is now registered with type=int | str, accepting both int and string values in TOML while keeping the string form working for backward compatibility. An explicit integer 0 is distinguished from the unset default. Co-authored-by: Cursor Grok 4.6 <cursoragent@cursor.com>
psf-chronographer
Bot
added
the
bot:chronographer:provided
Pierre-Sassoulas
requested changes
Aug 31, 2026
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
Member
There was a problem hiding this comment.
Looks reasonable thank you.
| result.assert_outcomes(passed=1, warnings=1) | ||
| assert result.ret == ExitCode.OK | ||
|
|
||
| @pytest.mark.filterwarnings("default::UserWarning") |
Member
There was a problem hiding this comment.
We don't need those automated tests, the int | str mechanism is already tested elsewhere.
Co-authored-by: CenFangyu <Dmao233@users.noreply.github.com>
Co-authored-by: CenFangyu <164994318+Dmao233@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14953
max_warningswas registered without a type, so native TOML integers (max_warnings = 0) were rejected even though the docs show an unquoted int.Register it as
int | strthe same way astruncation_limit_*._get_max_warnings()treatsNoneas unset so an explicit0is not the empty default.Checklist
closes #14953in the PR description and the commit.changelog/14953.bugfix.rst.AUTHORSin alphabetical order.Co-authored-bytrailer.